New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug fix] Crash when access to selected file was lost #417

Merged

philips77 merged 3 commits into main from bugfix/no-file

Nov 16, 2023

Member

philips77 commented Nov 16, 2023

It is possible to do the following:

Start DFU to a selected target device
Quit the app with a Back button when DFU is in progress -> this will kill the Activity and ViewModel
When DFU is complete (it runs in a foreground service, so wasn't affected) open app again
The app shows correctly status of the last operation
Try to do DFU again to the same or other device (without modifying the file)
This will cause a crash, as access to the file was granted for URI, which is no longer active

This PR fixes that by displaying an error instead. User can select the file again and repeat DFU.

philips77 added 3 commits

November 16, 2023 13:51


          Bug fix: Ensure access to selected file after Activity is recreated

965ec22


          Don't log full stacktrace for Access Denied error, that error is OK.

bd87d26


          UI: Fix file selection view

981b579

philips77 merged commit 96dddcb into main

1 check passed

philips77 deleted the bugfix/no-file branch

November 16, 2023 12:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment