Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initial iv index transition date set to null #524

Merged

Conversation

anees17861
Copy link
Contributor

This PR partially fixes #523.

It sets the default transition date to null and thus accepts an iv index update if it's receiving a beacon with higher ivindex in the network for the very first time

@roshanrajaratnam
Copy link
Member

Hi this looks good to me, did you get a chance to test this on your end?

@anees17861
Copy link
Contributor Author

I have tested with my changes only as of now. That was working. With just my changes though, it will always update as long as the received beacon is higher due to the lastTransition date issue that you fixed. Although that works in my case, it may raise some problems following the mesh spec.

I haven't been able to test your changes in your branch though as I would have to make my device go through 2 iv index updates to see the result which will take quite a bit of time (> 192 hours I'm assuming) for testing to just to get 1 result. Unfortunately I'm occupied with other tasks at the moment to perform this level of testing

@roshanrajaratnam
Copy link
Member

roshanrajaratnam commented Jul 1, 2022

OK, that's fine. FYI, the sample app contains a IV Test mode that overrides the time requirement. You could use this feature to do your testing as well :)

Thanks for your contribution. Really appreciate it.

@roshanrajaratnam roshanrajaratnam merged commit 5835326 into NordicSemiconductor:main Jul 1, 2022
@anees17861
Copy link
Contributor Author

@roshanrajaratnam Can you tell me how I can include this in my project (since it's not released on maven yet)? I would like to avoid putting it under source control of our main app. I heard about jitpack but since the repo is primarily an app, will it actually work?

@roshanrajaratnam
Copy link
Member

roshanrajaratnam commented Jul 5, 2022

Hey yes I have not had time to release before I went on vacation. However if you notice the sample app includes the project directly.
https://github.com/NordicSemiconductor/Android-nRF-Mesh-Library/blob/main/app/build.gradle#L94

@anees17861
Copy link
Contributor Author

Hi @roshanrajaratnam. Any plans on releasing a maven build?

@roshanrajaratnam
Copy link
Member

roshanrajaratnam commented Sep 9, 2022

Hi, I'm back at work on Tuesday and can do release. I need to fix a couple of other issues as well!

@roshanrajaratnam roshanrajaratnam linked an issue May 25, 2023 that may be closed by this pull request
@roshanrajaratnam roshanrajaratnam linked an issue Jun 1, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with IV index udpate IV index doesn't update on a imported network
2 participants