Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order of arguments to Feature constructor #546

Merged
merged 1 commit into from Dec 7, 2022
Merged

Fix order of arguments to Feature constructor #546

merged 1 commit into from Dec 7, 2022

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Dec 7, 2022

No description provided.

@Rawa Rawa changed the title Fix order of arguements to Feature constructor Fix order of arguments to Feature constructor Dec 7, 2022
@Rawa
Copy link
Contributor Author

Rawa commented Dec 7, 2022

See: #545

Order of arguments:

Android-nRF-Mesh-Library/mesh/src/main/java/no/nordicsemi/android/mesh/Features.java

Line 53 in 5298fd6

public Features(@FeatureState final int friend, @FeatureState final int lowPower, @FeatureState final int proxy, @FeatureState final int relay) {

@philips77 philips77 merged commit 5500f20 into NordicSemiconductor:main Dec 7, 2022
@philips77
Copy link
Member

Thanks for fixing all our bugs!

@roshanrajaratnam
Copy link
Member

Explains why the feature states never looked correct!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philips77 philips77 philips77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rawa @philips77 @roshanrajaratnam