Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of by one error #549

Merged

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Dec 12, 2022

No description provided.

@Rawa
Copy link
Contributor Author

Rawa commented Dec 12, 2022

Importing a json with a transmission count of 8 is broken and throws an error.

public static final int MIN_TRANSMIT_COUNT = 0b000;
public static final int MAX_TRANSMIT_COUNT = 0b111;

The values checked in the if statement was 0-7, and not 1-8 as by the text. This mean that the NodeDeserializer will fail if the value of the count is 8.

See deserializer:

https://github.com/NordicSemiconductor/Android-nRF-Mesh-Library/blob/main/mesh/src/main/java/no/nordicsemi/android/mesh/transport/NodeDeserializer.java#L111

@philips77
Copy link
Member

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants