Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Resuming Init object #485

Merged
merged 3 commits into from
Jun 29, 2022
Merged

Bugfix: Resuming Init object #485

merged 3 commits into from
Jun 29, 2022

Conversation

philips77
Copy link
Member

This PR fixes #479, a long existing issue where the Init Object was incorrectly resumed when reported offset was > 0.

The main part of this fix is here:

-let data = initPacket.subdata(in: Int(offset) ..< Int(initPacketLength - offset))
+let data = initPacket.subdata(in: Int(offset) ..< Int(initPacketLength))

Associated assert was also removed.

@philips77 philips77 merged commit c033410 into main Jun 29, 2022
@philips77 philips77 deleted the bugfix/incomplete-command-object branch June 29, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resume sending InitPacket doesn't work when offset > (initpacketlength - offset)
1 participant
@philips77