Utf8 support #60
Merged
Utf8 support #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fconnect-ble * 'master' of https://github.com/NordicSemiconductor/pc-nrfconnect-ble: change file names in component for consistency commit for changing file names
mrodem
approved these changes
Sep 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Thingy, since the device name can support 10 bytes,
so it now supports either
10 English letters,
or 5 Norwegian letters å/ø/æ
or 3 Chinese characters.
A English letter = 1 byte.
A 'ø', a 'æ' or a 'å' = 2 bytes.
A Chinese character = 3 bytes.
These scenarios have been tested.
However, there is another issue found.
When device is discovered while scanning, the device.name shows only 8 bytes,
although the name is displayed correctly which can support 10 bytes in GAP.
This happens the same on Android thingy app.