Log J-Link firmware string when selecting serial port #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention behind this action is to inform that we have recieved the device info, not that we are sending a request to get it. Renaming to make it more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #74, which is now conflicting with master. Using open/close from pc-nrfjprog-js so that getting the probe info does not slow down opening the serial port.
Note: I took the liberty to remove the connectivity firmware's transport type from the log output as it only said "transportType: 1", which is not very informative. Let me know if we still need to log this. In that case, I think we should show what the "1" actually means.