Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.7.0: update changelog and shared to v170 #227

Merged
merged 5 commits into from Apr 9, 2024

Conversation

KievDevel
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Apr 8, 2024

Add labels:

  • 'doc required' or 'doc not required'
  • 'ui required' or 'ui not required'

For UI review:

  • describe the changes
  • add pictures
  • add the relevant UI responsible(s) as a reviewer

@KievDevel KievDevel added doc not required All PRs either need "doc required" or "doc not required". ui not required All PRs either need "ui required" or "ui not required". labels Apr 8, 2024
Copy link
Contributor

@boundlesscalm boundlesscalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from my side but I think @greg-fer may have some comments about the changelog if I remember some conventions previously used though I may be wrong.
Do change the label to be "Docs required" in case greg hasn't looked over it, please.

@KievDevel
Copy link
Contributor Author

@boundlesscalm was copied from PPK changelog (same change) from approved PR by Greg but will doublecheck with him

@KievDevel KievDevel requested a review from greg-fer April 8, 2024 14:31
@KievDevel KievDevel added doc required This PR includes user-facing changes that need to be documented. and removed doc not required All PRs either need "doc required" or "doc not required". labels Apr 8, 2024
Copy link
Contributor

@greg-fer greg-fer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be shorter :D

Changelog.md Outdated Show resolved Hide resolved
KievDevel and others added 2 commits April 9, 2024 11:11
Co-authored-by: Grzegorz Ferenc <41291385+greg-fer@users.noreply.github.com>
@KievDevel KievDevel requested a review from greg-fer April 9, 2024 10:31
@KievDevel KievDevel merged commit 0dd9f28 into main Apr 9, 2024
3 checks passed
@KievDevel KievDevel deleted the release1.7.0-update-changelog-and-shared branch April 9, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc required This PR includes user-facing changes that need to be documented. ui not required All PRs either need "ui required" or "ui not required".
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants