This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Add Zigbee DFU image support #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bihanssen
reviewed
Sep 17, 2018
README.md
Outdated
| @@ -44,7 +45,7 @@ This will also retrieve and install all additional required packages. | |||
|
|
|||
| **Note**: When installing on macOS, you may need to add ` --ignore-installed six` when running pip. See [issue #79](https://github.com/NordicSemiconductor/pc-nrfutil/issues/79). | |||
|
|
|||
| **Note**: To use the `dfu ble` or `dfu thread` option you will need to set up your boards to be able to communicate with your computer. You can find additional information here: [Hardware setup](https://github.com/NordicSemiconductor/pc-ble-driver/blob/master/Installation.md#hardware-setup). | |||
| **Note**: To use the `dfu ble`, `dfu thread`, or `dfu zigbee` option you will need to set up your boards to be able to communicate with your computer. You can find additional information here: [Hardware setup](https://github.com/NordicSemiconductor/pc-ble-driver/blob/master/Installation.md#hardware-setup). | |||
There was a problem hiding this comment.
Grammar: I believe the last comma should be left out: /dfu thread, or dfu zigbee/dfu thread or dfu zigbee/
Same on line 106.
README.md
Outdated
| @@ -157,7 +158,7 @@ SoftDevice | FWID (sd-req) | |||
| `s140_nrf52_6.0.0` | 0xA9 | |||
| `s140_nrf52_6.1.0` | 0xAE | |||
|
|
|||
| **Note**: The Thread stack doesn't use a SoftDevice but --sd-req option is required for compatibility reasons. You can provide any value for the option as it is ignored during DFU. | |||
| **Note**: The Thread, and Zigbee stacks don't use a SoftDevice but --sd-req option is required for compatibility reasons. You can provide any value for the option as it is ignored during DFU. | |||
There was a problem hiding this comment.
Comma: /The Thread, and Zigbee stacks/The Thread and Zigbee stacks/
README.md
Outdated
| @@ -183,6 +184,12 @@ SD + APP | Yes | **See notes 1 and 2 below** | |||
| was added in nrfutil 3.1.0 and is required since 3.2.0 in case the package should contain SD (+ BL) + APP. Also, since version 3.2.0 the new ID is copied to `--sd-req` list so that | |||
| in case of a link loss during APP update the DFU process can be restarted. In that case the new SD would overwrite itself, so `--sd-req` must contain also the ID of the new SD. | |||
|
|
|||
| The boolean option '--zigbee' enables the generation of Zigbee update file in addition to the zip package. The following example demostrates the generation of such update file: | |||
There was a problem hiding this comment.
typo: /demostrates/demonstrates/
README.md
Outdated
| ``` | ||
| nrfutil pkg generate --hw-version 52 --sd-req 0 --application-version 0x01020101 --application nrf52840_xxaa.hex --key-file ../priv.pem app_dfu_package.zip --zigbee True --manufacturer-id 0xCAFE --image-type 0x1234 --comment good_image | ||
| ``` | ||
| **Note 3:** The generated Zigbee update file is named according to the recomendation of the Zigbee Specification ([Zigbee Cluster Library Specification 11.5 - Zigbee Document 07-5123-06](http://www.zigbee.org/~zigbeeor/wp-content/uploads/2014/10/07-5123-06-zigbee-cluster-library-specification.pdf)), so the user doesn't provide the name of the Update file. |
There was a problem hiding this comment.
typo: /recomendation/recommendation/
bihanssen
previously approved these changes
Sep 19, 2018
tomchy
force-pushed
the
feature/zigbee_dfu_image
branch
from
950b75e
to
cf009da
Compare
tomchy
force-pushed
the
feature/zigbee_dfu_image
branch
from
cf009da
to
8163c4b
Compare
bihanssen
approved these changes
Sep 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.