This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Fix mesh DFU response to missing packets #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes MBTLE-3686 * Fix several syntax errors * Fix incorrect indices * Add opcode name and fail reason string for 0x78FAFF (DFU DATA_RSP) to SerialPacket * Add requested missing packets to queue instead of attempting to send from inside the handler for the incoming request. This was blocking the read thread causing the ack to never arrive before timeout.
|
|
trond-snekvik
suggested changes
Jun 25, 2020
nordicsemi/dfu/dfu_transport_mesh.py
Outdated
| self.send_packet(SerialPacket(pkt)) | ||
| self.log_progress(100.0 / float(frames_count)) | ||
| time.sleep(self.interval) | ||
|
|
||
| # Wait for any final missing packet requests | ||
| time.sleep(4) |
There was a problem hiding this comment.
This timeout value should have a constant at the top like the others. Also, perhaps 4 seconds is a little short?
There was a problem hiding this comment.
Yeah it might be. 10 seconds might be better? I'll change it to 10 seconds and add a constant 👍
trond-snekvik
approved these changes
Jun 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes MBTLE-3686
SerialPacket
from inside the handler for the incoming request. This was blocking
the read thread causing the ack to never arrive before timeout.