This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
signing: access private key only once #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass a Signing() object 'signer' to Package() and Package.sign_firmware(),
instead of a 'key_file' string (path).
Access the private key only once, when generating 'signer', which:
1. Fixes a security issue where caller must write private key to disk
instead of passing it purely in memory eg:
nrfutil --key-file $(secure-key-retrieval)
2. Gives a small speed improvement.
Fixes NordicSemiconductor#327
Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
|
Bump; any comments on this one? |
|
Hi @siriobalmelli , |
bihanssen
approved these changes
Aug 5, 2020
|
@siriobalmelli, thanks for the contrib. The change looks good and works fine as far as I can tell. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass a Signing() object 'signer' to Package() and Package.sign_firmware(),
instead of a 'key_file' string (path).
Access the private key only once, when generating 'signer', which:
Fixes a security issue where caller must write private key to disk
instead of passing it purely in memory eg:
nrfutil --key-file $(secure-key-retrieval)
Gives a small speed improvement.
Fixes #327
Signed-off-by: Sirio Balmelli sirio@b-ad.ch