This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Align dfu zigbee command with pc-ble-driver>=0.15.0 #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchy
previously approved these changes
Jan 8, 2021
bihanssen
reviewed
Jan 11, 2021
The API of call_cmd method changed in pc-ble-driver-py 0.15.0. Previously, the CalledProcessError was raised when nrfjprog command failed. Since version 0.15.0, it is replaced by RuntimeError. Because RuntimeError has no returncode attribute, there is no good way to check the reason why command failed (parsing command output is not recommended, cause it can be changed). When requirements of nrfutil are updated, the old code can be removed.
jangalda-nsc
force-pushed
the
fix/align-zigbee-dfu-command-with-pc-ble-driver-0.15.0-api-changes
branch
from
5b1139d
to
b437d98
Compare
|
just a friendly reminder |
bihanssen
approved these changes
Jan 13, 2021
bihanssen
deleted the
fix/align-zigbee-dfu-command-with-pc-ble-driver-0.15.0-api-changes
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API of call_cmd method changed in pc-ble-driver-py 0.15.0. Previously, the CalledProcessError was raised when nrfjprog command failed. Since version 0.15.0, it is replaced by RuntimeError.
Because RuntimeError has no returncode attribute, there is no good way to check the reason why command failed (parsing command output is not recommended, cause it can be changed).
When requirements of nrfutil are updated, the old code can be removed.