Remove checks to support BL + APP updates #371
Conversation
|
|
| @@ -132,10 +132,6 @@ def _validate(self): | |||
| raise RuntimeError("sd_size is not set. It must be set when type is SOFTDEVICE") | |||
| elif self.init_command.type == pb.BOOTLOADER and self.init_command.bl_size == 0: | |||
| raise RuntimeError("bl_size is not set. It must be set when type is BOOTLOADER") | |||
| elif self.init_command.type == pb.SOFTDEVICE_BOOTLOADER and \ | |||
There was a problem hiding this comment.
Why is this particular change needed?
There was a problem hiding this comment.
From what I can see from the original devzone ticket, it helps for devices with little flash space, since the SD takes too much space.
"
[...]
Please allow creating APP+BL (but not SD) DFU packages in nrfutil!
This is an issue especially on devices with less flash space, such as the nrf52810, where APP+BL+SD updates are not possible because the SD it too big. [...]
"
This comment was marked as duplicate.
This comment was marked as duplicate.
| @@ -132,10 +132,6 @@ def _validate(self): | |||
| raise RuntimeError("sd_size is not set. It must be set when type is SOFTDEVICE") | |||
| elif self.init_command.type == pb.BOOTLOADER and self.init_command.bl_size == 0: | |||
| raise RuntimeError("bl_size is not set. It must be set when type is BOOTLOADER") | |||
| elif self.init_command.type == pb.SOFTDEVICE_BOOTLOADER and \ | |||
There was a problem hiding this comment.
From what I can see from the original devzone ticket, it helps for devices with little flash space, since the SD takes too much space.
"
[...]
Please allow creating APP+BL (but not SD) DFU packages in nrfutil!
This is an issue especially on devices with less flash space, such as the nrf52810, where APP+BL+SD updates are not possible because the SD it too big. [...]
"
|
We do do not have capacity to maintain and release new versions of this utility. |
As explained in the Nordic Devzone ticket (*1) updates of APP+BL are necessary some times. There is no real reason why nrfutil forbids the creation of such packages. This commit removes these checks and I have successfully created an APP+BL package and updated my device.
(*1) https://devzone.nordicsemi.com/f/nordic-q-a/84879/feature-request-please-allow-app-bl-dfu-upgrades-in-nrfutil