Vip controller and CRD #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add vip api type and webhook move configmap handling to vip controller Refactor the shared functions to a "common" module remove vip entry in trench CRD validate overlaping of vips in a namespace
mandydydy
force-pushed
the
vip-controller
branch
from
916a7a8
to
8616656
Compare
LionelJouin
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webhook validates
vip address format and length(alpha supports 1 address per vip)
the label "trench" must be defined in a vip
the label "trench" is not allowed to change in an update
Move configmap handling from trench controller to vip controller
Update vip status to "accepted" if vip information is added to its corresponding configmap, and "rejected" if it fails the validation