Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the async api when a connection error triggers a slot update #144

Merged
merged 20 commits into from
Mar 14, 2023
Merged

Use the async api when a connection error triggers a slot update #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
3a8e3c6
Keep specific error from failing cluster_update_route() calls
bjosv Feb 25, 2023
9552d86
Refactor code for updating known cluster nodes
bjosv Feb 20, 2023
9a9d850
Remove use of Redis config cluster-node-timeout
bjosv Feb 21, 2023
5e36f24
Update slot map immediately for communication problems
bjosv Feb 26, 2023
2d9cb0c
Update timeout-handling-test
bjosv Feb 27, 2023
2013eec
Fix redisClusterAsyncDisconnect()
bjosv Feb 27, 2023
ae5501a
Add lastConnectionAttempt to redisClusterNode
bjosv Mar 6, 2023
c83f290
Communication errors triggers slot update using the async api
bjosv Feb 27, 2023
c2642ab
Build on windows
bjosv Mar 7, 2023
09bf236
Fixup: Use lastSlotmapUpdateAttempt
bjosv Mar 13, 2023
908e8fd
Add dictGetRandomKey() from hiredis
bjosv Mar 1, 2023
32afdf0
Fixup: Perform 3 attempts to randomly pick a connected node
bjosv Mar 13, 2023
a5d928f
fixup: remove randomizer seed from library
bjosv Mar 13, 2023
9385482
Revert "Add dictGetRandomKey() from hiredis"
bjosv Mar 13, 2023
dc5d570
Revert "Fixup: Perform 3 attempts to randomly pick a connected node"
bjosv Mar 13, 2023
696ebc3
Fixup: Select node close to a random index
bjosv Mar 13, 2023
29f6c59
Add info about need of srandom() to README
bjosv Mar 13, 2023
5f6a783
fixup: handle low checkIndex cornercase
bjosv Mar 13, 2023
76ada61
Fixup: Select a connected node primarily
bjosv Mar 13, 2023
82e8708
fixup: remove unused include
bjosv Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,15 @@ callbacks have been executed. After this, the disconnection callback is executed
There are a few hooks that need to be set on the cluster context object after it is created.
See the `adapters/` directory for bindings to *libevent* and a range of other event libraries.

## Other details

### Random number generator

This library uses [random()](https://linux.die.net/man/3/random) while selecting
a node used for requesting the cluster topology (slotmap). A user should seed
the random number generator using [srandom()](https://linux.die.net/man/3/srandom)
to get less predictability in the node selection.

### Allocator injection

Hiredis-cluster uses hiredis allocation structure with configurable allocation and deallocation functions. By default they just point to libc (`malloc`, `calloc`, `realloc`, etc).
Expand Down
Loading