Update slotmap when slot is not served by any node #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sync-API will update the slotmap before attempting to send a command when the slot is not served by any cluster node. The async-API will initate the slotmap update in parallell so that the next command might have an updated slotmap.
Its former name `cluster_update_route()` can be removed by the define HIRCLUSTER_NO_OLD_NAMES, which would break the build.
zuiderkwast
reviewed
Sep 28, 2023
Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
This reverts commit 4d2299a.
|
I reverted the callback handling for AUTH commands, to be added via separate PR. Also removed the use of the eventloop in the testcases that didn't need any events for its testing. |
zuiderkwast
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sync-API will now update the slotmap before attempting to send a command when the slot is not served.
The async-API will initate the slotmap update in parallell so that the next command might have an updated slotmap.
This also fix an additional issue by using the correct function name for
redisClusterUpdateSlotmap().The former name
cluster_update_route()is not defined whenHIRCLUSTER_NO_OLD_NAMESis defined, which would break the build.Fixes #191