Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 #5

Merged
merged 7 commits into from
Nov 21, 2016
Merged

V2 #5

merged 7 commits into from
Nov 21, 2016

Conversation

steinbergkh
Copy link

  • add server log functions and aliases
  • add basic unit tests
  • implement internal logging functions

andyday
andyday reviewed Nov 18, 2016
View reviewed changes
olog.js
// 4. write record to stream
appOpts.stream.write(record)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use stringify to convert object to json string before writing. this change should be reflected in the tests.

@steinbergkh steinbergkh merged commit e31258a into v1 Nov 21, 2016
@andyday
Copy link
Contributor

andyday commented Nov 28, 2016

this branch can be deleted now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyday andyday andyday left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@steinbergkh @andyday