fix: 🐛Fixes TS definition for logger and updates script for running l…

…ocally (#66) * fix: 🐛Fixes TS definition for logger * chore: 🤖Use correct boolean value when running locally * refactor: 💡 Rename a parameter
NoriSte · Dec 12, 2019 · b4eb742 · b4eb742
1 parent 841efff
commit b4eb742
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/cypress-run.js b/cypress-run.js
@@ -1,10 +1,10 @@
 const npm = require('npm')
 
 npm.load(() => {
-  const uploadRecordings = process.env.npm_package_config_cypressUploadRecordings;
+  const uploadRecordings = process.env.npm_package_config_cypressUploadRecordings === 'true';
   const key = process.env.CYPRESS_RECORD_KEY;
-  if(uploadRecordings && !key) {
-    throw 'Missing Cypress record key';
+  if (uploadRecordings && !key) {
+    throw "Missing Cypress record key";
   }
   const options = uploadRecordings && key ? ['--record', '--key', key] : [];
   npm.commands['run-script'](['cy:run', ...options]);

diff --git a/index.d.ts b/index.d.ts
@@ -10,7 +10,7 @@ interface WaitUntilOptions {
   customMessage?: string;
   verbose?: boolean;
   customCheckMessage?: string;
-  logger?: (WaitUntilLog) => any;
+  logger?: (logOptions: WaitUntilLog) => any;
   log?: boolean;
 }
 

diff --git a/package-lock.json b/package-lock.json