Mark the component test chapters as obsolete #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muratkeremozcan
approved these changes
Mar 30, 2023
| @@ -318,6 +289,40 @@ If a test cannot produce reliable results, it reduces confidence in the tests an | |||
|
|
|||
| <br/> <br/> | |||
|
|
|||
| # `9. Obsolete chapters` | |||
There was a problem hiding this comment.
Why don't we just delete these?
Because if users bookmarked it (or sent it by email, etc.), if they do not find it... what happened? Why they cannot access the contents that were important to them? A lot of ambiguity remains in their mind... instead, an obsolete section explaining why they are obsolete wipe out all the ambiguity IMO 😊 |
muratkeremozcan
approved these changes
Apr 1, 2023
NoriSte
force-pushed
the
obsolete-chapters
branch
from
2fdd8a3
to
94bfe20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only missing thing here is mentioning @muratkeremozcan book somewhere (to do in a dedicated PR).