Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

Bugfix layout positions #47

Merged
merged 4 commits into from
Dec 10, 2019
Merged

Bugfix layout positions #47

merged 4 commits into from
Dec 10, 2019

Conversation

salvan13
Copy link
Contributor

fixes #46

Copy link
Collaborator

@asgvard asgvard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can you make an npm release too please?

@salvan13 salvan13 merged commit 40fbc90 into master Dec 10, 2019
@shirakaba
Copy link
Contributor

Just to mention that I made the same bugfix independently in shirakaba/synchronous-layout, though wasn't sure whether it would break some other use case, so can add my confidence to this PR given that NoriginMedia are approving of it too.

@salvan13 salvan13 deleted the bugfix-layout-positions branch December 12, 2019 12:51
shirakaba pushed a commit to shirakaba/react-spatial-navigation that referenced this pull request Jan 23, 2020
* master:
  Bugfix layout positions (NoriginMedia#47)
  Updated Package lock
  ISSUE-40: Added Jest, a new way to find the nearest child, etc. (NoriginMedia#45)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus jumps on wrong component
4 participants