Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-/5x5PF test fails on Debian unstable for arm64, ppc64el, s390x, powerpc and ppc64 architectures #161

Closed
jgmbenoit opened this issue Nov 15, 2017 · 7 comments

Comments

@jgmbenoit
Copy link
Contributor

jgmbenoit commented Nov 15, 2017

normaliz 3.4.1 was finally uploaded. As claimed in the title, here, test-/5x5PF test fails on Debian unstable for some architectures.
Can you reproduce it on a least one of them ? If not, please let me know what I can do.
Cheers, Jerome

@jgmbenoit jgmbenoit changed the title test-/5x5PF.diff fails on arm64, ppc64el, s390x, powerpc and ppc64 architectures test-/5x5PF test fails on Debian unstable for arm64, ppc64el, s390x, powerpc and ppc64 architectures Nov 15, 2017
@w-bruns
Copy link
Contributor

w-bruns commented Nov 15, 2017

This is an extremely sensitive test since it uses floating point arithmetic for a system of equations and requires the result to give exact integers. I was surprised that it works at all. I think the only possibility is to remove it.

@jgmbenoit
Copy link
Contributor Author

Is there a way to control the error ? Otherwise, instead of removing the test, it can be kept without taking into account its failure as far as the check is concerned. In short, deterministic tests are required by robots.

@w-bruns
Copy link
Contributor

w-bruns commented Nov 17, 2017

So we leave it as it is.

@w-bruns w-bruns closed this as completed Nov 17, 2017
@jgmbenoit
Copy link
Contributor Author

Ok. From my side, as Debian maintainer, it is not satisfactory. I am on my way to write a patch to neutralize it.

jgmbenoit added a commit to jgmbenoit/Normaliz that referenced this issue Nov 17, 2017
Description: upstream: tests: ignore extremely sensitive tests
 Ignore an extremely sensitive test [1] that fails on arm64, ppc64el,
 s390x, powerpc and ppc64 architectures at the time of writing.
 [1] Normaliz#161
Origin: vendor, Debian
Author: Jerome Benoit <calculus@rezozer.net>
Last-Update: 2017-11-17
@w-bruns
Copy link
Contributor

w-bruns commented Nov 19, 2017

I am thinking about moving this test to a special directory so that it can only be run at special request.
In fact, the choice of the algorithm ProjectionFloat in this test is unnatural for the task. For me it was an attempt to see how far I can go with floating point arithmetic.
The natural choices are Projection or DualMode, both using integer arithmetic.

@w-bruns w-bruns reopened this Nov 19, 2017
@jgmbenoit
Copy link
Contributor Author

I suspected some kind of numerical experiment. Otherwise, moving this kind of test to a dedicated directory sounds as a good idea.

@w-bruns
Copy link
Contributor

w-bruns commented Nov 30, 2017

5x5PF moved to test-Special

@w-bruns w-bruns closed this as completed Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants