Skip to content

Commit

Permalink
A few corrections as per, PJW.
Browse files Browse the repository at this point in the history
  • Loading branch information
NormanDunbar committed Dec 10, 2018
1 parent 34e8473 commit 6ca0c12
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 4 deletions.
3 changes: 2 additions & 1 deletion sphinx/source/F/few.rst
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,6 @@ then return the error code of that job.

See :ref:`ew`,
:ref:`exec-w`,
:ref:`jobs`.
:ref:`jobs`,
:ref:`quit`.

2 changes: 1 addition & 1 deletion sphinx/source/F/fex-m.rst
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ newly started job will be killed whenever its owner job is killed.

::

jobid = FEX\_M(win1_qmac)
the_job_id = FEX_M(win1_qmac)

Will execute Qmac as a job owned by the current S*BASIC interpreter. When the
current interpreter ceases to exist, the new Qmac job will also be killed.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
.. _hot_getstuff-dlr:
.. _hot-getstuff-dlr:

HOT_GETSTUFF$
=============
Expand All @@ -25,5 +25,5 @@ like ALT-SHIFT-SPACE

**CROSS-REFERENCE**

See :ref:`get_stuff-dlr`, :ref:`hot_stuff`.
See :ref:`get-stuff-dlr`, :ref:`hot-stuff`.

23 changes: 23 additions & 0 deletions sphinx/source/PER_Corrections.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
Norm, I guess your main motivation here is to update the format of the manual, not to act as an editor and maintainer. However, since you currently are adding new material, now might be the time to correct and augment that material. I dont mean to carp from the sidelines, so please feel free to ignore if you dont find it helpful!

FEX_M Example: jobid = FEX\_M(win1_qmac)

Unfortunate use of jobid, as that is a valid keyword in its own right. Then theres the backslash. Might I suggest:

ID = FEX_M(win1_qmac), or <job id> = FEX_M(win1_qmac), or something?

FEW CROSS-REFERENCE: See EW, EXEC_W, JOBS.

To this should be added QUIT, as QUIT [<return parameter>] is the only real way to return an error (or some other long word message) to FEW(). The QUIT entry would then also need to be updated.


Under WM_XXX there is the following explanation:

"..The items are referenced by a 4-digit hex number (16-bit value) as per the list under the entry for WM_INK, or the decimal number equivalent. These numbers should not be used in standard INK, PAPER and BORDER statements – they are not colour values, merely an index to an entry in a list of colour values. They should be used with the WM_x equivalent commands, which will look up the colour values to be used for the item numbers in the list."

This could be clarifed to say that in the context of the WM_XXX keywords, numbers represent indexes, but those same numbers are, of course, valid colours when used with their non-WM_XXX brethren. As it stands, it looks like one shouldnt use the numbers $200 to $238 (512 to 568) as valid colours. Could be confusing when at first trying to get to grips with palettes!

Of course, WM_BORDER needs a whole chapter of its own.. But that, perhaps, is for the future.

HOT_GETSTUFF$ - You probably meant for the cross referenced keywords to be links, and in UPPER case..
Per

0 comments on commit 6ca0c12

Please sign in to comment.