Unit tests and fixes for R/models.R

[nikolase90]

Summarized

• Changes cases of 'something' to "something" in R/models.R
• Modifies predict_model.* R/models.R so that it handles both data.frame and matrix as input.
• Adds check for ranger. If you're passing a classification model it needs to be a probability forest (if that is not the case you'll only get predicted classes and not probabilities).
• Adds tests in tests/testthat/test-models.R

[martinju]

This is good to have.
Since we only support binary classification and not multiclass classification, we should probably have checks for that too. I.e. a stop in either the model_type (preferrably) or predict_model if a multiclass model is provided. Can you fix that?

[nikolase90]

This is good to have.
Since we only support binary classification and not multiclass classification, we should probably have checks for that too. I.e. a stop in either the model_type (preferrably) or predict_model if a multiclass model is provided. Can you fix that?

👍

[nikolase90]

@martinju Updated with tests for multi-classification.

[martinju]

Great! Just fix the typo and we are good.

[nikolase90]

Fixed typos with 7ed8625.