Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding non-exact grouping #277

Merged
merged 6 commits into from
Sep 17, 2021
Merged

Adding non-exact grouping #277

merged 6 commits into from
Sep 17, 2021

Conversation

martinju
Copy link
Member

This PR adds non-exact grouping, i.e. the kernelSHAP method of sampling n_combinations of the 2^no_groups different groups available to use in the computation. It is essentially a duplicate of the code for features.

Other edits:

  • Restructured the if-else checks for whether to switch to exact when a too large number of n_combinations is specified.
  • switched to update=F for one test against a disk stored file

Copy link
Contributor

@JensWahl JensWahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants