Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use skip_if_not_installed() over requireNamespace branch #320

Closed

Conversation

MichaelChirico
Copy link

This is preferable for a variety of reasons, e.g.

  • Save an extra indentation
  • Testthat report output is clearer by indicating that certain tests were skipped if MASS is missing
  • skip_if_not_installed() is more readable than if (!requireNamespace(., quietly = TRUE))

@martinju
Copy link
Member

Thanks for this, I agree with your suggestion. As written in the top of the readme, the package is undergoing big structural changes. In particular, all tests are rewritten, such that it does not make sense to merge this now. So far these tests only use package available in all R installations, but I will take your advice when moving outside of that. Thanks again. Closing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants