Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space before year in incollection #4

Conversation

mlhetland
Copy link

Just following the pattern for similar drivers.

@NorwegianRockCat
Copy link
Owner

I don't see anything wrong with this, but could you add an incollection item to the tests? That way we can make sure it is correct for the future too.

@mlhetland
Copy link
Author

Certainly! I was about to, but I guess I got lazy ;D

@mlhetland
Copy link
Author

There are some other issues with years that I'm not sure how to address (and issues seem to be disabled for this repo?):

  • For a bare-bones misc entry, there will be a spurious comma between the title and the year (because of an unconditional \addcomma).
  • The use of organization+location+date in misc leads to an additional year at the end. Seems to work fine if replaced by organization+location, but I'm not sure if that's how it should be handled.

@mlhetland
Copy link
Author

Ah, no, organization+location doesn't exist, I guess.

@NorwegianRockCat
Copy link
Owner

Hi @mlhetland

I enabled issues if you want to put the issue there. I believe I just forked the original repo because it wasn't working with newer versions of BibLaTeX. So, I didn't have the expectation that I would start collecting changes. :-)

Anyway, I'll look a bit closer at these later today.

@mlhetland
Copy link
Author

Indeed!

Well, I'm not sure where these efforts are best directed, but your fork seemed more active/responsive (as is also pointed out by an issue at latextemplates), which is why I added some PRs here :-)

This was referenced Jun 22, 2020
@NorwegianRockCat
Copy link
Owner

LGTM. Thank you.

@NorwegianRockCat NorwegianRockCat merged commit d986f6a into NorwegianRockCat:master Jun 22, 2020
@mlhetland mlhetland deleted the mlhetland/incollection-space branch June 22, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants