library: Allow to update compute resources #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This is not perfect. We always display changes since the Foreman API doesn't return the password but we have one and so the comparison fails. But it's far better than issuing "no changes required" as we do right now.
agx
force-pushed
the
update_compute_resource
branch
from
bac250a
to
b29e78a
Compare
|
I would prefer to remove the password from the compared dictionaries so the comparison does not return changed, |
|
Since #48 is merged this is no longer needed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not perfect. We always display changes since the Foreman API
doesn't return the password but we have one and so the comparison fails.
But it's far better than issuing "no changes required" as we do right
now.