Use gcm for encryption #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandroutn
reviewed
Mar 27, 2024
| $data = $iv . $cipherText; | ||
|
|
||
| return $data; | ||
| return $iv . $cipherText . $cipher->getTag(); |
iganulevics
approved these changes
Mar 28, 2024
leandroutn
reviewed
Mar 28, 2024
| { | ||
| //Check if phpseclib v3 is used | ||
| //needed for comaptibility with Magento 2.4 versions | ||
| if (class_exists("phpseclib3\Crypt\AES")) { |
There was a problem hiding this comment.
so, this selection between phpseclib3 and phpseclib is not needed anymore? aka: assured to be there?
leandroutn
reviewed
Mar 28, 2024
| } | ||
|
|
||
| $cipher = new AES('gcm'); | ||
| $cipher->setKeyLength(256); |
There was a problem hiding this comment.
to be extra clear, let's also add $cipher->setTagLength(128);
leandroutn
reviewed
Mar 28, 2024
| $cipher->setKey($secret); | ||
| $cipher->setIV($iv); | ||
| $iv = Random::string(12); |
There was a problem hiding this comment.
minor: from the functionality perspective, looks good. I'd use constants for nonce and tag lengths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Documentation:
Checklist: