Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excessive loggin when confirming order via Shopware API #245

Merged
merged 6 commits into from Aug 11, 2020

Conversation

supercid
Copy link
Member

@supercid supercid commented Aug 11, 2020

Description

Remove unnecessary logging
Fix missing ISO code in customer buyer object, which would invalidate orders

Related Issue

Closes #244

Motivation and Context

Excessive and unnecessary logging

How Has This Been Tested?

PUT this:

{
    "paymentStatusId": 10,
    "orderStatusId": 8,
    "trackingCode": "237948723894789234",
    "comment": "Neuer Kommentar",
    "transactionId": "0",
    "clearedDate": "2019-10-18T17:58:17+0000"
}

http://shopware.dev.nos.to:8080/api/orders/15?XDEBUG_SESSION_START=PHPSTORM
with stock sample data.

Check the logs

Documentation:

N/A

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@supercid supercid added the bug label Aug 11, 2020
@supercid supercid added this to the 2.4.7 milestone Aug 11, 2020
@supercid supercid self-assigned this Aug 11, 2020
@supercid supercid changed the base branch from develop to master August 11, 2020 08:52
@supercid supercid marked this pull request as ready for review August 11, 2020 09:05
@supercid supercid merged commit 314c3d5 into master Aug 11, 2020
@supercid supercid deleted the hotfix/2.4.7-order-confirmation-logging branch August 11, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order confirmation via API excessive logging
3 participants