languages/nim: init #205
Merged
languages/nim: init #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotAShelf
added
enhancement
|
Tested the PR on Linux and it seems to work fine. On MacOS, NimLSP crashes because of segment violation. I have created an issue (PMunch/nimlsp#178 (comment)), meanwhile maybe mark the support for nim as broken on MacOS? |
|
I'll add an assertion |
|
@FrothyMarrow pushed a commit to assert on Darwin systems. Given I don't have a way to test it, would appreciate if you could test it. |
|
The assert works but it will also fail the maximal builds on Darwin. I believe it would be better to have it either disabled by default or add a check there as well. |
due to nimlsp not working properly on darwin
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take two, properly rebased this time.