Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style #7

Closed
wants to merge 0 commits into from
Closed

Code style #7

wants to merge 0 commits into from

Conversation

IrishBruse
Copy link
Contributor

@IrishBruse IrishBruse commented Mar 5, 2022

  • I went and added a better .editorconfig and made changed to suit the project
  • Updated the bindings to use the proper commit with submodules
  • Cleaned up alot of the code that was now giving errors.
  • All tests still pass

@jasonswearingen
Copy link
Member

Hi @IrishBruse I am happy for your contributions!!! can you please make sure that whatever you do, the native raylib.dll process and binding gen round-trip still works? I tried to document it in the powershell script https://github.com/NotNotTech/Raylib-CsLo/blob/main/binding-gen/regen.ps1 and also in that folder readme.md

The reason for this, is that for me, the key requirement is that when there are (future) changes to the native raylib.dll, that it is very easy to detect breaking changes (and thus, to fix them).

I will find time tonight or tomorrow morning to do a code review.

@IrishBruse
Copy link
Contributor Author

So for the binding gen I have ran it and it works and regenerates everything but with some warnings I don't how fix these if they are an issue
image

@jasonswearingen
Copy link
Member

jasonswearingen commented Mar 5, 2022

I went ahead and code reviewed via the web, everything looks good.

So for the binding gen I have ran it and it works and regenerates everything but with some warnings I don't how fix these if they are an issue

The binding gen warnings look fine (known issues with malloc I mentioned in the readme), but I will compare with my baseline when I build/deploy the nuget package later today.

@IrishBruse IrishBruse closed this Mar 6, 2022
@IrishBruse IrishBruse deleted the code-style branch March 6, 2022 01:56
@IrishBruse
Copy link
Contributor Author

I'm gonna make a new commit I some how managed to completely screw up my branch lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants