Skip to content
This repository has been archived by the owner on Aug 21, 2021. It is now read-only.

Issue with branch 0xv2 support on ingest #127

Closed
alejoloaiza opened this issue Nov 1, 2018 · 1 comment
Closed

Issue with branch 0xv2 support on ingest #127

alejoloaiza opened this issue Nov 1, 2018 · 1 comment

Comments

@alejoloaiza
Copy link

Hi, I'm trying to validate the signature of an order using the ingest.go but it seems there is an issue with the api, it shows the signature is not correct, any ideas?

{
"makerAddress": "0x9e56625509c2f60af937f23b7b532600390e8c8b",
"takerAddress": "0xa2b31dacf30a9c50ca473337c01d8a201ae33e32",
"feeRecipientAddress": "0xb046140686d052fff581f63f8136cce132e857da",
"senderAddress": "0xa2b31dacf30a9c50ca473337c01d8a201ae33e32",
"makerAssetAmount": "10000000000000000",
"takerAssetAmount": "20000000000000000",
"makerFee": "100000000000000",
"takerFee": "200000000000000",
"expirationTimeSeconds": "1532560590",
"salt": "1532559225",
"makerAssetData": "0xf47261b0000000000000000000000000e41d2489571d322189246dafa5ebde1f4699f498",
"takerAssetData": "0x02571792000000000000000000000000371b13d97f4bf77d724e78c16b7dc74099f40e840000000000000000000000000000000000000000000000000000000000000063",
"exchangeAddress": "0x12459c951127e0c374ff9105dda097662a027093",
"signature": "0x012761a3ed31b43c8780e905a260a35faefcc527be7516aa11c0256729b5b351bc33"
}

This json is taken from SRA website https://github.com/0xProject/standard-relayer-api/blob/master/http/v2.md

@AusIV
Copy link
Contributor

AusIV commented Nov 2, 2018

I raised an issue on the SRA documentation website. That signature is malformed for a couple of reasons.

That aside, this order would be rejected because:

  • It's expired
  • The feeRecipientAddress is not considered valid by OpenRelay
  • The exchangeAddress is the 0x v1 exchange contract address, but the order is formatted for 0x v2.

@AusIV AusIV closed this as completed May 13, 2019
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants