Random generation tweaks #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converting a set to a list does not enforce a deterministic ordering. I could have sorted the list, but that doesn't feel right either. Using the set was a premature optimization anyways. Closes #86.
Just a nicety to make reproducibility easier.
In implementing the random rule generation, I had mistakenly believed that 'f' meant 'step and draw' while 'F' meant only 'step'. In reality the opposite is true. The consequence of this mistake is that most generated rules will result in pictures with gaps. This is a partial fix for #83
Notgnoshi
force-pushed
the
ag/more-random
branch
from
d05d442
to
f88ded9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#66, #67, #83, #86
Closes #86