-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
We intentionally removed mail support, sorry. |
Looks like your implementation is incorrect because the message isn't a string. |
Really?? May I know way?
|
That's essentially what we ran into. In reality, people wish to send multiple content types or attatch stuff, so notifyme is unsuitable for mail. Also, I think you mean "array" rather than "Array". They're very different. "array" is a php native type, but "Array" is an object. |
Message must be a string. |
Your gateway does NOT implement https://github.com/notifymehq/contracts/blob/master/src/GatewayInterface.php correctly, basically. |
I was replying for my phone and by email, so when I asked
It was regarding why you guys removed the email support and not why my implementation was not correct. And what do you mean with:
|
Because basically Email has too many variables to make into one simple implementation. |
I mean, the only diference is that beside the message it self , you also need to specify a subject. All the others are all optionals. And even for that, you could provide all this settings for your
|
So I've updated the gateway to implement the gateway contract correctly and to make into one simple implementation. If you guys like it and want to make it official, fee free for it. If not, I'll release as an unofficial version of it. Because It makes sense for us to use it like that and maybe for someone else, but it's your call. |
I just don't agree that this makes sense. The whole idea of notifyme is that developers should not care that the message is ending up as an email, and normally emails have very specific extra formatting, more like letters, so notifyme isn't suitable. |
Notifyme is meant to be more like a texting people type of thing. |
Ok. |
Hi guys, so I've created the gateway for Mail using NotifyMeHQ, let me know what you guys think.
Here is the link of if:
https://github.com/descubraomundo/notifymehq-mail