feat: support for normalize chinese title #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. Makes sense. One thing I'm not sure about. Do Chinese characters work as urls in all browsers? |
URL use RFC-1738, It basically support us-ascii sets, browsers will encode chinese charaters automatically, but there are differences between different browsers. As far as i know, some old browser like IE also support encode character to gb2312. for this PR, It simply make |
|
Looking good. thanks for this! |
|
added to v4.11.4 |
chuyun
pushed a commit
to chuyun/react-notion-x
that referenced
this pull request
Jul 13, 2023
feat: support for normalize chinese title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for issue #176 .