Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support reducer result #473

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

maxswjeon
Copy link

@maxswjeon maxswjeon commented Apr 23, 2023

Description

There is a reducer type of collection view, which is table type when created on Notion Website.

Notion Test Page ID

d297b76916ff4749b49648ac9984c358

@vercel
Copy link

vercel bot commented Apr 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-notion-x ✅ Ready (Inspect) Visit Preview Apr 23, 2023 5:03pm
react-notion-x-minimal-demo ✅ Ready (Inspect) Visit Preview Apr 23, 2023 5:03pm

@maxswjeon
Copy link
Author

I don't know why the test fails... I cannot see the Vercel logs

@maxswjeon
Copy link
Author

Found it. ReducerCollectionView should extend BaseCollectionView

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant