Skip to content

Commit

Permalink
fix: sove pub scoring issues
Browse files Browse the repository at this point in the history
  • Loading branch information
NourEldinShobier committed Aug 29, 2022
1 parent 83ffab6 commit 33d51d6
Show file tree
Hide file tree
Showing 5 changed files with 37 additions and 24 deletions.
10 changes: 5 additions & 5 deletions example/pubspec.lock
Expand Up @@ -21,7 +21,7 @@ packages:
path: ".."
relative: true
source: path
version: "0.11.0"
version: "0.11.1"
characters:
dependency: transitive
description:
Expand Down Expand Up @@ -89,7 +89,7 @@ packages:
name: flutter_svg
url: "https://pub.dartlang.org"
source: hosted
version: "0.22.0"
version: "1.1.4"
flutter_test:
dependency: "direct dev"
description: flutter
Expand Down Expand Up @@ -143,14 +143,14 @@ packages:
name: path_drawing
url: "https://pub.dartlang.org"
source: hosted
version: "0.5.1+1"
version: "1.0.1"
path_parsing:
dependency: transitive
description:
name: path_parsing
url: "https://pub.dartlang.org"
source: hosted
version: "0.2.1"
version: "1.0.1"
petitparser:
dependency: transitive
description:
Expand Down Expand Up @@ -239,7 +239,7 @@ packages:
name: xml
url: "https://pub.dartlang.org"
source: hosted
version: "5.4.1"
version: "6.1.0"
sdks:
dart: ">=2.17.0 <3.0.0"
flutter: ">=3.0.0"
5 changes: 3 additions & 2 deletions lib/features/breadcrumb/breadcrumb.widget.dart
Expand Up @@ -113,8 +113,9 @@ class CBreadcrumb extends StatelessWidget {
Widget build(BuildContext context) {
return Wrap(
crossAxisAlignment: WrapCrossAlignment.center,
children:
props.children.length > props.breadcrumbsLimit ? _displayOverflowedBreadcrumbs() : _displayAllBreadcrumbs(),
children: props.children.length > props.breadcrumbsLimit
? _displayOverflowedBreadcrumbs()
: _displayAllBreadcrumbs(),
);
}
}
32 changes: 22 additions & 10 deletions lib/features/button/button.widget.dart
Expand Up @@ -97,7 +97,8 @@ class _CButtonRegular extends _CButtonBase {
_CButtonRegularState createState() => _CButtonRegularState();
}

class _CButtonRegularState extends State<_CButtonRegular> with _CButtonStateBase {
class _CButtonRegularState extends State<_CButtonRegular>
with _CButtonStateBase {
List<Widget> _buildTrailing() {
final result = <Widget>[];

Expand Down Expand Up @@ -146,29 +147,34 @@ class _CButtonRegularState extends State<_CButtonRegular> with _CButtonStateBase
height: dimensions.height,
duration: _Styles.backgroundColorAnimation['duration'],
curve: _Styles.backgroundColorAnimation['curve'],
decoration: BoxDecoration(color: _Styles.backgroundColor[widget.props.kind]![state]!),
decoration: BoxDecoration(
color: _Styles
.backgroundColor[widget.props.kind]![state]!),
),
),
Positioned.fill(
child: AnimatedContainer(
height: dimensions.height,
duration: _Styles.firstBorderAnimation[kind]!['duration'],
curve: _Styles.firstBorderAnimation[kind]!['curve'],
decoration: BoxDecoration(border: _Styles.firstBorder[kind]![state]!),
decoration: BoxDecoration(
border: _Styles.firstBorder[kind]![state]!),
),
),
Positioned.fill(
child: AnimatedContainer(
height: dimensions.height,
duration: _Styles.secondBorderAnimation['duration'],
curve: _Styles.secondBorderAnimation['curve'],
decoration: BoxDecoration(border: _Styles.secondBorder[kind]![state]!),
decoration: BoxDecoration(
border: _Styles.secondBorder[kind]![state]!),
),
),
SizedBox(
height: dimensions.height,
child: Padding(
padding: EdgeInsets.symmetric(horizontal: _Styles.padding[widget.props.size]!),
padding: EdgeInsets.symmetric(
horizontal: _Styles.padding[widget.props.size]!),
child: Row(
mainAxisSize: MainAxisSize.min,
mainAxisAlignment: MainAxisAlignment.center,
Expand Down Expand Up @@ -207,7 +213,8 @@ class _CButtonIconOnly extends _CButtonBase {
_CButtonIconOnlyState createState() => _CButtonIconOnlyState();
}

class _CButtonIconOnlyState extends State<_CButtonIconOnly> with _CButtonStateBase {
class _CButtonIconOnlyState extends State<_CButtonIconOnly>
with _CButtonStateBase {
@override
Widget build(BuildContext context) {
_setStateVariables();
Expand All @@ -230,26 +237,31 @@ class _CButtonIconOnlyState extends State<_CButtonIconOnly> with _CButtonStateBa
height: dimensions.height,
duration: _Styles.backgroundColorAnimation['duration'],
curve: _Styles.backgroundColorAnimation['curve'],
decoration: BoxDecoration(color: _Styles.backgroundColor[widget.props.kind]![state]!),
decoration: BoxDecoration(
color:
_Styles.backgroundColor[widget.props.kind]![state]!),
),
AnimatedContainer(
width: dimensions.width,
height: dimensions.height,
duration: _Styles.firstBorderAnimation[kind]!['duration'],
curve: _Styles.firstBorderAnimation[kind]!['curve'],
decoration: BoxDecoration(border: _Styles.firstBorder[kind]![state]!),
decoration:
BoxDecoration(border: _Styles.firstBorder[kind]![state]!),
),
AnimatedContainer(
width: dimensions.width,
height: dimensions.height,
duration: _Styles.secondBorderAnimation['duration'],
curve: _Styles.secondBorderAnimation['curve'],
decoration: BoxDecoration(border: _Styles.secondBorder[kind]![state]!),
decoration: BoxDecoration(
border: _Styles.secondBorder[kind]![state]!),
),
SizedBox(
width: dimensions.width,
height: dimensions.height,
child: Align(alignment: Alignment.center, child: widget.props.icon),
child: Align(
alignment: Alignment.center, child: widget.props.icon),
),
],
),
Expand Down
8 changes: 4 additions & 4 deletions pubspec.lock
Expand Up @@ -75,7 +75,7 @@ packages:
name: flutter_svg
url: "https://pub.dartlang.org"
source: hosted
version: "0.22.0"
version: "1.1.4"
flutter_test:
dependency: "direct dev"
description: flutter
Expand Down Expand Up @@ -129,14 +129,14 @@ packages:
name: path_drawing
url: "https://pub.dartlang.org"
source: hosted
version: "0.5.1+1"
version: "1.0.1"
path_parsing:
dependency: transitive
description:
name: path_parsing
url: "https://pub.dartlang.org"
source: hosted
version: "0.2.1"
version: "1.0.1"
petitparser:
dependency: transitive
description:
Expand Down Expand Up @@ -225,7 +225,7 @@ packages:
name: xml
url: "https://pub.dartlang.org"
source: hosted
version: "5.4.1"
version: "6.1.0"
sdks:
dart: ">=2.17.0 <3.0.0"
flutter: ">=3.0.0"
6 changes: 3 additions & 3 deletions pubspec.yaml
@@ -1,6 +1,6 @@
name: carbon_flutter
description: A Flutter version of Carbon Design System
version: 0.11.0
description: UI library that translates IBM's Carbon Design System into Flutter
version: 0.11.1
homepage: https://github.com/NourEldinShobier/carbon-flutter

environment:
Expand All @@ -9,7 +9,7 @@ environment:

dependencies:
vector_math: ^2.1.0
flutter_svg: ^0.22.0
flutter_svg: ^1.1.4
pmvvm: ^4.0.1
flutter:
sdk: flutter
Expand Down

0 comments on commit 33d51d6

Please sign in to comment.