Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Confirm Order button now active when cargo shuttle is at Central #2469

Merged
merged 2 commits into from
May 15, 2024

Conversation

NovaBot13
Copy link
Collaborator

@NovaBot13 NovaBot13 commented May 15, 2024

Original PR: tgstation/tgstation#83152

About The Pull Request

Currently, the cargo console's Confirm Order button is active when the supply shuttle is shipside. This PR flips it, so it's active at Central.

Why It's Good For The Game

Makes more sense to confirm the order when you're actually going to have the shuttle coming to the station.

Changelog

🆑
qol: The "Confirm Order" button on Cargo consoles is now active when the cargo shuttle is at Central Command instead of at the station.
/:cl:

Shadow-Quill and others added 2 commits May 15, 2024 00:34
…152)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Currently, the cargo console's Confirm Order button is active when the
supply shuttle is shipside. This PR flips it, so it's active at Central.

## Why It's Good For The Game

Makes more sense to confirm the order when you're actually going to have
the shuttle coming to the station.

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

:cl:
qol: The "Confirm Order" button on Cargo consoles is now active when the
cargo shuttle is at Central Command instead of at the station.
/:cl:
@NovaBot13 NovaBot13 added Quality of Life Enhancing gameplay through the smallest means possible UI We make the game less playable, but with round edges labels May 15, 2024
@vinylspiders vinylspiders enabled auto-merge (squash) May 15, 2024 00:44
@vinylspiders vinylspiders merged commit 32785fa into master May 15, 2024
23 of 24 checks passed
@vinylspiders vinylspiders deleted the upstream-merge-83152 branch May 15, 2024 01:53
NovaBot13 added a commit that referenced this pull request May 15, 2024
github-actions bot added a commit that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Enhancing gameplay through the smallest means possible UI We make the game less playable, but with round edges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants