Allow to serve static files from filesystem #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this? Can it be reviewed and merged? |
|
@piranna, thanks for the PR. I will review it shortly. Serving files is always a potential vulnerability an should be reviewed respectively. |
|
Thanks for your answer :-) Yes, I know, I did this just only to be able to serve the HLS files from the same server :-) |
mrlika
reviewed
Feb 15, 2024
| let data = undefined; | ||
|
|
||
| try { | ||
| data = readFileSync(`${process.cwd()}${path}`); |
There was a problem hiding this comment.
Serving files is very responsible. This line is a potential vulnerability that allows reading arbitrary files in the file system.
There was a problem hiding this comment.
Instead of just clossing the PR, you can suggest a proper fix for this... I think resolve the absolute path and ensure falls under the current working dir would be enough.
|
The PR contains vulnerabilities |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #38.