catch "no promotion template" errors silently

NovemLinguae · Dec 30, 2021 · 3714544 · 3714544
1 parent 39664e0
commit 3714544
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/index.php b/src/index.php
@@ -101,10 +101,17 @@
 		// STEP A - READ PAGE CONTAINING {{User:NovemBot/Promote}} =============
 		$nominationPageWikicode = $wapi->getpage($nominationPageTitle);
 
-		$p->abortIfPromotionTemplateMissing($nominationPageWikicode, $nominationPageTitle);
-		$p->abortIfAddToTopic($nominationPageWikicode, $nominationPageTitle);
+		// not all pings from featured topic pages need to be acted on
+		// silent error to prevent error spam
+		try {
+			$p->abortIfPromotionTemplateMissing($nominationPageWikicode, $nominationPageTitle);
+		} catch (Exception $e) {
+			$eh->logError('{{t|User:NovemBot/Promote}} template missing from page.');
+			continue;
+		}
 
 		// couple of checks
+		$p->abortIfAddToTopic($nominationPageWikicode, $nominationPageTitle);
 		$topicBoxWikicode = $p->getTopicBoxWikicode($nominationPageWikicode, $nominationPageTitle);
 		$topicBoxWikicode = $p->setTopicBoxViewParameterToYes($topicBoxWikicode);
 		$mainArticleTitle = $p->getMainArticleTitle($topicBoxWikicode, $nominationPageTitle);