fix processDelistForGAList() over-deletion bug

NovemLinguae · Jan 18, 2023 · 0ac9582 · 0ac9582
1 parent 1bef0d1
commit 0ac9582
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/GANReviewTool/modules/GARCloserWikicodeGenerator.js b/GANReviewTool/modules/GARCloserWikicodeGenerator.js
@@ -115,7 +115,7 @@ __TOC__`;
 
 	processDelistForGAList(wikicode, articleToRemove) {
 		if ( arguments.length !== 2 ) throw new Error('Incorrect # of arguments');
-		let regex = new RegExp(`'{0,3}"?\\[\\[${this.regExEscape(articleToRemove)}.*\\]\\]"?'{0,3}\\n`, 'g');
+		let regex = new RegExp(`'{0,3}"?\\[\\[${this.regExEscape(articleToRemove)}(?:\\|[^\\]]+)?\\]\\]"?'{0,3}\\n`, 'gi');
 		wikicode = wikicode.replace(regex, '');
 		return wikicode;
 	}

diff --git a/GANReviewTool/tests/GARCloserWikicodeGenerator.test.js b/GANReviewTool/tests/GARCloserWikicodeGenerator.test.js
@@ -1011,7 +1011,6 @@ describe('processDelistForGAList(wikicode, articleToRemove)', () => {
 		expect(wg.processDelistForGAList(wikicode, articleToRemove)).toBe(output);
 	});
 
-
 	it(`Should handle rare case of the item being listed twice`, () => {
 		let articleToRemove = `Multilateral Investment Guarantee Agency`;
 		let wikicode =
@@ -1041,6 +1040,30 @@ describe('processDelistForGAList(wikicode, articleToRemove)', () => {
 ''[[The Accounting Review]]''
 [[Mzoli's]]
 }}
+`;
+		expect(wg.processDelistForGAList(wikicode, articleToRemove)).toBe(output);
+	});
+
+	it(`Should delete the exact article name only`, () => {
+		let articleToRemove = `Fish`;
+		let wikicode =
+`===== Globalization =====
+{{#invoke:Good Articles|subsection|
+[[Globalization and women in China]]
+[[Fish allergy]]
+[[Fish]]
+[[Fisher (animal)]]
+[[Spanish flu]]
+}}
+`;
+		let output =
+`===== Globalization =====
+{{#invoke:Good Articles|subsection|
+[[Globalization and women in China]]
+[[Fish allergy]]
+[[Fisher (animal)]]
+[[Spanish flu]]
+}}
 `;
 		expect(wg.processDelistForGAList(wikicode, articleToRemove)).toBe(output);
 	});