Bug to fix in ebics_config #62

matmicro · 2023-01-13T15:49:19Z

There is a bug in the below function : def_update_order_number(self, OrderID)

OderIDs are improperly updated on next :
A00Z is followed by A01Z, A02Z, A03Z, ...
which should be A010, A011, A012... A01Z, A020, A021...

This leads to reach extremely fast ZZZZ !

File ebics_config.py, line 487 :
Should replace :

   if c == 'Z':
      continue

By:

   if c == 'Z':
      o_list[-i] = '0'
      continue

Regards

The text was updated successfully, but these errors were encountered:

luc-demeyer · 2023-01-15T21:45:43Z

Thanks a lot for this contribution.
I have applied your suggested patch to account_ebics version 8.0 up to version 16.0.

luc-demeyer added a commit that referenced this issue Jan 15, 2023

fix _update_order_number, cf. #62

b8b0921

luc-demeyer added a commit that referenced this issue Jan 15, 2023

fix _update_order_number, cf. #62

a48e3b4

luc-demeyer added a commit that referenced this issue Jan 15, 2023

fix _update_order_number, cf. #62

2091269

luc-demeyer added a commit that referenced this issue Jan 15, 2023

fix _update_order_number, cf. #62

18a0390

luc-demeyer added a commit that referenced this issue Jan 15, 2023

fix _update_order_number, cf. #62

a10c44e

luc-demeyer added a commit that referenced this issue Jan 15, 2023

fix _update_order_number, cf. #62

99e352e

luc-demeyer added a commit that referenced this issue Jan 15, 2023

fix _update_order_number, cf. #62

9adbfb9

luc-demeyer added a commit that referenced this issue Jan 15, 2023

fix _update_order_number, cf. #62

0a7bc48

luc-demeyer closed this as completed Jan 15, 2023

NoviatBot pushed a commit that referenced this issue Jan 27, 2024

fix _update_order_number, cf. #62

b9a07e5

Provide feedback