add circle ci config (#54)

* add circle ci config
* fix broken tests and linting

.changeset/c5ab78fe/changes.json

@@ -0,0 +1,4 @@
+{
+  "releases": [{ "name": "@changesets/cli", "type": "patch" }],
+  "dependents": []
+}

.changeset/c5ab78fe/changes.md

@@ -0,0 +1 @@
+Remove unused function parseChangesetCommit

.circleci/config.yml

@@ -0,0 +1,80 @@
+version: 2
+jobs:
+  test:
+    docker:
+      - image: circleci/node:10.6.0
+    working_directory: ~/repo
+    steps:
+      - checkout
+      - restore_cache:
+          keys:
+            - v1-dependencies-{{ checksum "yarn.lock" }}
+            # fallback to using the latest cache if no exact match is found
+            - v1-dependencies-
+      - run:
+          name: Install
+          command: yarn install --pure-lockfile
+      - run:
+          name: GitSetup
+          command: git config --global user.email "you@example.com" && git config --global user.name "Your Name"
+      - run:
+          name: "Jest Tests"
+          command: yarn jest --ci --runInBand --coverage --reporters=default --reporters=jest-junit
+          environment:
+            JEST_JUNIT_OUTPUT: "reports/junit/js-test-results.xml"
+      - run:
+          name: "Upload Coverage"
+          command: yarn codecov
+      - store_test_results:
+          path: reports/junit
+      - store_artifacts:
+          path: reports/junit
+      - save_cache:
+          paths:
+            - ~/.cache/yarn
+            - node_modules
+          key: v1-dependencies-{{ checksum "yarn.lock" }}
+
+  typescript:
+    docker:
+      - image: circleci/node:10.6.0
+    working_directory: ~/repo
+    steps:
+      - checkout
+      - restore_cache:
+          keys:
+            - v1-dependencies-{{ checksum "yarn.lock" }}
+            # fallback to using the latest cache if no exact match is found
+            - v1-dependencies-
+      - run:
+          name: Install
+          command: yarn install --pure-lockfile
+      - run:
+          name: "Typescript"
+          command: yarn types:check
+
+  lint:
+    docker:
+      - image: circleci/node:10.6.0
+    working_directory: ~/repo
+    steps:
+      - checkout
+      - restore_cache:
+          keys:
+            - v1-dependencies-{{ checksum "yarn.lock" }}
+            # fallback to using the latest cache if no exact match is found
+            - v1-dependencies-
+      - run:
+          name: Install
+          command: yarn install --pure-lockfile
+      - run:
+          name: "ESLint"
+          command: yarn lint
+
+workflows:
+  version: 2
+  test:
+    jobs:
+      - test
+      - lint
+      - typescript

.eslintignore

@@ -1,2 +1,3 @@
-dist/
+dist
 __fixtures__
+node_modules

.eslintrc

@@ -11,7 +11,13 @@
     "standard/computed-property-even-spacing": "off",
     "no-template-curly-in-string": "off",
     "camelcase": "off",
-    "import/no-duplicates": "off"
+    "import/no-duplicates": "off",
+    "no-useless-constructor": "off",
+    "no-unusued-vars": "off",
+    "@typescript-eslint/no-unused-vars": [
+      "error",
+      { "argsIgnorePattern": "^_", "ignoreRestSiblings": true }
+    ]
   },
   "overrides": [
     {
@@ -40,6 +46,12 @@
       "rules": {
         "prefer-const": "off"
       }
+    },
+    {
+      "files": ["packages/cli/default-files/config.js"],
+      "rules": {
+        "@typescript-eslint/no-unused-vars": "off"
+      }
     }
   ]
 }

package.json

@@ -55,6 +55,7 @@
     "@babel/preset-typescript": "^7.3.3",
     "@typescript-eslint/eslint-plugin": "^1.9.0",
     "@typescript-eslint/parser": "^1.9.0",
+    "codecov": "^3.5.0",
     "dotenv": "^8.0.0",
     "eslint": "^5.16.0",
     "eslint-config-prettier": "^4.2.0",
@@ -67,6 +68,7 @@
     "eslint-plugin-standard": "^4.0.0",
     "jest": "^24.7.1",
     "jest-fixtures": "^0.5.0",
+    "jest-junit": "^6.4.0",
     "preconstruct": "^0.0.70"
   },
   "preconstruct": {

packages/cli/src/commands/add/__tests__/add.js

@@ -41,7 +41,7 @@ const mockUserResponses = mockResponses => {
   const summary = mockResponses.summary || "summary message mock";
   const shouldCommit = mockResponses.shouldCommit || "n";
   askCheckboxPlus.mockReturnValueOnce(Object.keys(mockResponses.releases));
-  Object.entries(mockResponses.releases).forEach(([pkg, type]) =>
+  Object.entries(mockResponses.releases).forEach(([_pkg, type]) =>
     askList.mockReturnValueOnce(type)
   );
   askQuestion.mockReturnValueOnce(summary);

packages/cli/src/commands/add/__tests__/changesetsPeerDeps.test.js

@@ -47,7 +47,7 @@ const mockUserResponses = mockResponses => {
   const summary = mockResponses.summary || "summary message mock";
   const shouldCommit = mockResponses.shouldCommit || "n";
   askCheckboxPlus.mockReturnValueOnce(Object.keys(mockResponses.releases));
-  Object.entries(mockResponses.releases).forEach(([pkg, type]) =>
+  Object.entries(mockResponses.releases).forEach(([_pkg, type]) =>
     askList.mockReturnValueOnce(type)
   );
   askQuestion.mockReturnValueOnce(summary);

packages/cli/src/commands/bump/__tests__/consume.js

@@ -13,7 +13,6 @@ const consoleError = console.error;
 
 jest.mock("../../../utils/cli");
 jest.mock("../../../utils/git");
-jest.mock("../../add/parseChangesetCommit");
 jest.mock("../../../utils/logger");
 
 git.add.mockImplementation(() => Promise.resolve(true));

packages/cli/src/commands/release/__tests__/releaseCommand.test.js

@@ -7,7 +7,6 @@ import runRelease from "..";
 jest.mock("../../../utils/cli");
 jest.mock("../../../utils/git");
 jest.mock("../../../utils/logger");
-jest.mock("../../add/parseChangesetCommit");
 jest.mock("../../../utils/bolt-replacements");
 
 git.tag.mockImplementation(() => Promise.resolve(true));