Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm error silencing, fail fast if no yaml lib exists #35

Merged
merged 4 commits into from Jan 4, 2023
Merged

rm error silencing, fail fast if no yaml lib exists #35

merged 4 commits into from Jan 4, 2023

Conversation

tomwojcik
Copy link
Contributor

Fixes #29

  • drop global error silencing on import / during init eval
  • fail fast if required dependencies are missing

@NowanIlfideme NowanIlfideme self-assigned this Jan 4, 2023
@NowanIlfideme
Copy link
Owner

Tested locally, this works and gives the following readable error:

...
ModuleNotFoundError: No module named 'yaml'
...
ImportError: Could not import ruamel.yaml or pyyaml, please install at least one of them.

Will just need to check the mypy errors failing in the PR 😃

Honestly, I don't quite remember why install-without-extras was ignored. I think it was a versioning-related problem, which was fixed by switching to bump2version (but I forgot to revert the try-except block).

@NowanIlfideme NowanIlfideme merged commit 712837f into NowanIlfideme:main Jan 4, 2023
@tomwojcik tomwojcik deleted the #29-raise-meaningful-error-on-missing-yaml-parser branch January 5, 2023 08:01
@NowanIlfideme
Copy link
Owner

Thank you for noticing this, and sorry for a slow response and merge - busy New Year's. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install without extras result in broken package
2 participants