Add zacs:style, strip zacs declarations from output #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpopek
approved these changes
Jul 13, 2020
Comment on lines
80
to
+82
| + "platform": "web", // or "native" | ||
| + "production": true // pass `false` to enable debug attributes | ||
| + "production": true, // pass `false` to enable debug attributes | ||
| + "keepDeclarations": false // pass `true` to keep zacs.xxx variable declarations in output |
There was a problem hiding this comment.
Are all properties required? Maybe it would be a good idea to highlight all optional props and their default values?
There was a problem hiding this comment.
nope, not required - but so what?
There was a problem hiding this comment.
To indicate what's important and what can be configured later. It might be helpful for newcomers fiddling with the lib
|
@radex our discussion should not block merging - do you want me to merge it? |
|
@michalpopek yep! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zacs:style={{ width: 10}}. This feels a lot simpler, more natural than defining separate props for individual style attributes... I'm considering whether namespacing is even necessary - we could make it astyle={}attribute, and it would feel just right. But I'm not sure, so I'm taking the conservative pathconst Foo = zacs.foo(...)) from output code, by default, since it doesn't do anything anyway. I initially considered to only do this in production mode, since accidentally making a (non-transpired) component out of a ZACS declaration would call the ZACS runtime to show a helpful error. But on the other hand,Blah is not definedalso tells you something is wrong, and there's nothing more frustrating than having your code work perfectly fine in development, but break builds in CI or whenever you get to make production builds.