fix: support for python >= 3.8 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platform.dist was removed in python 3.8, parse /etc/lsb-release instead
No clue why this line is present though
Ubuntu 20.04LTS uses ipython3==7.13.0-1 https://packages.ubuntu.com/focal/ipython3 Using 5.7.0 prevents any imports when using the ipython shell. Not 100% about giving None as `info` to ExectionResult [1], but the ExecutionInfo [2] object it's supposed to hold only seems to be used for its __repr__ attribute for debugging. [1] https://github.com/ipython/ipython/blob/a8accc9ab5aa97c2fd21149d421f0c6917e060b2/IPython/core/interactiveshell.py#L319 [2] https://github.com/ipython/ipython/blob/a8accc9ab5aa97c2fd21149d421f0c6917e060b2/IPython/core/interactiveshell.py#L284
Add support for ipython 7.13.0
|
Hi @valensc , would you mind having a look at this PR ? |
valensc
approved these changes
Nov 6, 2022
|
Thank u for the update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
platform.dist was removed in python 3.8, parse /etc/lsb-release instead