Add tests for core implementation #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge dev into master
Add test for Shell. Tweak ConsoleShellTest.
Change LineParser to have two methods: one to parse for execution, and one to parse for tab completion.
Change signature of Shell.commands to return an Iterable instead of a Seq.
Change CommandDelegator.commandsByName to be a SortedMap.
Add test for CommandTabCompleter.tabComplete with an empty Seq. Note that a LineParser should not actually allow such a situation to occur.
Change OutputSink.write(CharSequence) to write(String), and writeln(CharSequence) to writeln(String).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak and concretize traits and implementation.