Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "nuget spec" command generates a .nuspec file with an iconUrl #10400

Closed
loic-sharma opened this issue Dec 18, 2020 · 2 comments · Fixed by NuGet/NuGet.Client#4021
Closed
Assignees
Labels
Area:PackageDefinition Category:Quality Week Issues that should be considered for quality week help wanted Considered good issues for community contributions. Product:NuGet.exe NuGet.exe Type:Bug

Comments

@loic-sharma
Copy link
Contributor

loic-sharma commented Dec 18, 2020

Problem

Our docs for creating a package uses the nuget spec command. This generates a nuspec with an iconUrl, which is a deprecated property.

Once we fix this issue, we should update our docs. See: https://github.com/NuGet/docs.microsoft.com-nuget/issues/1966

Detailed repro steps so we can see the same problem

  1. Run nuget spec using nuget.exe v5.8.0
  2. Inspect the contents of the generated nuspec file:
<?xml version="1.0" encoding="utf-8"?>
<package >
  <metadata>
    <id>Package</id>
    <version>1.0.0</version>
    <authors>Ninja</authors>
    <requireLicenseAcceptance>false</requireLicenseAcceptance>
    <license type="expression">MIT</license>
    <projectUrl>http://project_url_here_or_delete_this_line/</projectUrl>
    <iconUrl>http://icon_url_here_or_delete_this_line/</iconUrl>
    <description>Package description</description>
    <releaseNotes>Summary of changes made in this release of the package.</releaseNotes>
    <copyright>$copyright$</copyright>
    <tags>Tag1 Tag2</tags>
    <dependencies>
      <group targetFramework=".NETStandard2.1">
        <dependency id="SampleDependency" version="1.0.0" />
      </group>
    </dependencies>
  </metadata>
</package>

The iconUrl feature is deprecated: https://docs.microsoft.com/en-us/nuget/reference/nuspec#iconurl

@aortiz-msft aortiz-msft added Category:Quality Week Issues that should be considered for quality week help wanted Considered good issues for community contributions. labels Jan 4, 2021
@erdembayar erdembayar self-assigned this Feb 22, 2021
@erdembayar erdembayar modified the milestone: Sprint 2021-03 Mar 1, 2021
@erdembayar
Copy link
Contributor

@loic-sharma
I believe it's not complete removal of icon-url, but we're replacing with icon, is it right?

@JonDouglas
Copy link
Contributor

Yep that's right @erdembayar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:PackageDefinition Category:Quality Week Issues that should be considered for quality week help wanted Considered good issues for community contributions. Product:NuGet.exe NuGet.exe Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants