Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate package namespaces information to the restore command #10736

Closed
nkolev92 opened this issue Apr 8, 2021 · 1 comment · Fixed by NuGet/NuGet.Client#4111
Closed

Propagate package namespaces information to the restore command #10736

nkolev92 opened this issue Apr 8, 2021 · 1 comment · Fixed by NuGet/NuGet.Client#4111
Assignees
Labels
Area:PackageSourceMapping Issues related to the package source mapping feature Functionality:Restore Priority:2 Issues for the current backlog. Style:PackageReference Type:Bug

Comments

@nkolev92
Copy link
Member

nkolev92 commented Apr 8, 2021

Child of #10727.

Blocked on #10731

@nkolev92
Copy link
Member Author

@kartheekp-ms

There's some extremely basic work that has been started here:

https://github.com/NuGet/NuGet.Client/compare/dev-feature-packageNamespaces...dev-nkolev92-addDataInRestoreRequest?expand=1.

Note that for this particular task, what is in the current branch might be sufficient.

How I'd expect this to go:

RestoreRequest has the namespaces configuration.

From there, the configuration might go into the RemoteWalkContext and/or flow into the https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Core/NuGet.Commands/RestoreCommand/ProjectRestoreCommand.cs.

The actual package probing happens in https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Core/NuGet.DependencyResolver.Core/ResolverUtility.cs.

So you'd need to make sure that all the calls for resolution:

Note that the resolver utility does a lot of caching based on a package id. Note that this caching should remain project level, to avoid potential polluting due to different configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:PackageSourceMapping Issues related to the package source mapping feature Functionality:Restore Priority:2 Issues for the current backlog. Style:PackageReference Type:Bug
Projects
None yet
2 participants