Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overallocations of WhereListIterator in DependencyWalker.CreateGraphNode #10920

Closed
jebriede opened this issue Jun 4, 2021 · 0 comments · Fixed by NuGet/NuGet.Client#4096
Closed
Assignees
Labels
Category:Quality Week Issues that should be considered for quality week Functionality:Restore PerfWins Tenet:Performance Performance issues Type:Bug

Comments

@jebriede
Copy link
Contributor

jebriede commented Jun 4, 2021

The DependencyWalker uses a LINQ Where in the CreateGraphNode method on a hot code path and the result is a large amount of WhereListIterators being allocated.

 Name                                                                                                                                 	Inc %	          Inc
 Type WhereListIterator`1[NuGet.LibraryModel.LibraryDependency]                                                                      	  0.6	   58,290,408
+ clr!?                                                                                                                              	  0.6	   58,290,408
 + system.core.ni!?                                                                                                                  	  0.6	   58,290,408
  + nuget.dependencyresolver.core!NuGet.DependencyResolver.RemoteDependencyWalker+<CreateGraphNode>d__3.MoveNext()                   	  0.6	   52,176,240
  |+ mscorlib.ni!System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[System.__Canon].Start[System.__Canon](System.__Canon ByRef)	  0.6	   52,176,240
  | + nuget.dependencyresolver.core!RemoteDependencyWalker.CreateGraphNode                                                           	  0.6	   52,176,240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Quality Week Issues that should be considered for quality week Functionality:Restore PerfWins Tenet:Performance Performance issues Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants